From 817515901ca237b9f47e2001f7d65f9e38249eb1 Mon Sep 17 00:00:00 2001 From: Tyler Wilcox Date: Fri, 30 Jan 2026 22:25:01 -0500 Subject: [PATCH] Reorganization --- .../robolib/drivesystems/swerve/SwerveBuilder.java | 4 ++-- ...eDriveSubsystem.java => SwerveDriveSystem.java} | 12 +++++++----- .../robolib/drivesystems/swerve/SwerveModule.java | 14 ++++++++++++++ 3 files changed, 23 insertions(+), 7 deletions(-) rename lib/src/main/java/org/fairportrobotics/frc/robolib/drivesystems/swerve/{SwerveDriveSubsystem.java => SwerveDriveSystem.java} (94%) diff --git a/lib/src/main/java/org/fairportrobotics/frc/robolib/drivesystems/swerve/SwerveBuilder.java b/lib/src/main/java/org/fairportrobotics/frc/robolib/drivesystems/swerve/SwerveBuilder.java index ffbbf52..abdfc26 100644 --- a/lib/src/main/java/org/fairportrobotics/frc/robolib/drivesystems/swerve/SwerveBuilder.java +++ b/lib/src/main/java/org/fairportrobotics/frc/robolib/drivesystems/swerve/SwerveBuilder.java @@ -57,8 +57,8 @@ public class SwerveBuilder { return this; } - public SwerveDriveSubsystem build() { - return new SwerveDriveSubsystem(pigeonId, canBusObj, maxLinearVelMetersSecond, maxAngularVelRadiansSecond, + public SwerveDriveSystem build() { + return new SwerveDriveSystem(pigeonId, canBusObj, maxLinearVelMetersSecond, maxAngularVelRadiansSecond, modules.toArray(size -> new SwerveModule[size])); } diff --git a/lib/src/main/java/org/fairportrobotics/frc/robolib/drivesystems/swerve/SwerveDriveSubsystem.java b/lib/src/main/java/org/fairportrobotics/frc/robolib/drivesystems/swerve/SwerveDriveSystem.java similarity index 94% rename from lib/src/main/java/org/fairportrobotics/frc/robolib/drivesystems/swerve/SwerveDriveSubsystem.java rename to lib/src/main/java/org/fairportrobotics/frc/robolib/drivesystems/swerve/SwerveDriveSystem.java index 1d928d0..b23974b 100644 --- a/lib/src/main/java/org/fairportrobotics/frc/robolib/drivesystems/swerve/SwerveDriveSubsystem.java +++ b/lib/src/main/java/org/fairportrobotics/frc/robolib/drivesystems/swerve/SwerveDriveSystem.java @@ -16,9 +16,10 @@ import edu.wpi.first.math.kinematics.SwerveDriveKinematics; import edu.wpi.first.math.kinematics.SwerveModulePosition; import edu.wpi.first.math.kinematics.SwerveModuleState; import edu.wpi.first.units.measure.Angle; +import edu.wpi.first.wpilibj2.command.Subsystem; import edu.wpi.first.wpilibj2.command.SubsystemBase; -public class SwerveDriveSubsystem extends SubsystemBase{ +public class SwerveDriveSystem implements Subsystem{ private SwerveDriveKinematics driveKiniematics; private ChassisSpeeds chassisSpeeds; @@ -35,7 +36,7 @@ public class SwerveDriveSubsystem extends SubsystemBase{ private double mLastSimTime = 0; - public SwerveDriveSubsystem(int pigeonId, CANBus canBus, double maxLinearVelMetersSecond, double maxAngularVelRadiansSecond, SwerveModule... modules){ + public SwerveDriveSystem(int pigeonId, CANBus canBus, double maxLinearVelMetersSecond, double maxAngularVelRadiansSecond, SwerveModule... modules){ MAX_LINEAR_SPEED = maxLinearVelMetersSecond; MAX_ANGULAR_SPEED = maxAngularVelRadiansSecond; @@ -54,7 +55,6 @@ public class SwerveDriveSubsystem extends SubsystemBase{ @Override public void periodic() { - super.periodic(); SwerveModuleState[] moduleStates = driveKiniematics.toSwerveModuleStates(chassisSpeeds); for(int i=0; i